Match port properties (e.g. USB vid/pid) case insensitively against board.txt values (in e.g. board list) #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows both uppercase and lowercase properties (e.g. vid and pid)
from boards.txt and matches what the Java IDE does:
https://github.com/arduino/Arduino/blob/5e30bec23/arduino-core/src/cc/arduino/packages/BoardPort.java#L185
matthijskooijman
force-pushed
the
vidpid-insensitive
branch
from
5f58eb3 to
ebac06c
Compare
cmaglie
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows both uppercase and lowercase properties (e.g. vid and pid)
from boards.txt and matches what the Java IDE does:
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
Bugfix
USB ids or other identifying properties from a (serial) port are matched case sensitively, so if boards.txt specifies uppercase usb ids,
board listdoes not match the port with the corresponding board.Properties are matched case insensitively, just like the Java IDE does: https://github.com/arduino/Arduino/blob/5e30bec23/arduino-core/src/cc/arduino/packages/BoardPort.java#L185
No.